Skip to content

Finish sync of test infrastructure with "template" assets #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2021
Merged

Finish sync of test infrastructure with "template" assets #241

merged 6 commits into from
Aug 6, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 5, 2021

Some additional changes required for a full sync, which were non included in the first attempt (#227)

@per1234 per1234 changed the title Finish sync of test infrastructure with " Finish sync of test infrastructure with "template" assets Aug 5, 2021
@per1234 per1234 requested review from silvanocerza and umbynos August 5, 2021 21:57
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement labels Aug 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #241 (08c80e2) into main (bf7335b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          43       43           
  Lines        6320     6320           
=======================================
  Hits         5679     5679           
  Misses        530      530           
  Partials      111      111           
Flag Coverage Δ
unit 89.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7335b...08c80e2. Read the comment docs.

per1234 added 6 commits August 6, 2021 01:59
This script is now developed and maintained in a dedicated repository for such reusable project assets. This means that
there is no need for its test code to be checked in to this repository. I did this by accident after having failed to
follow the installation instructions carefully and am now correcting my mistake.
The `workflow_dispatch` event allows triggering the workflow via the GitHub web interface. This makes it easy to trigger
an immediate workflow run after some relevant external change.

The `repository_dispatch` event allows triggering workflows via the GitHub API. This might be useful for triggering an
immediate check in multiple relevant repositories after an external change, or some automated process. Although we don't
have any specific need for this event at the moment, the event has no impact on the workflow, so there is no reason
against having it. It is the sort of thing that can end up being useful if it is already in consistently in place, but
not worth setting up on demand, since the effort to set it up is greater than the effort to trigger all the workflows
manually.
The official GitHub Actions documentation specifies the hosted macOS runner names use the `macos` prefix. Although the
non-compliant case previously in use clearly does work, there is no guarantee it will continue to do so, so it's safest
to follow the documentation exactly.
No functional change, and neither is necessarily superior, but this is how it is in the "template", and so it must be
here as well.
Although the other works as well, this is the style specified in the official GitHub Actions reference and used in the
"template" workflow.
There are two file extensions in common use for YAML files: `.yaml` and `.yml`. Although this project uses `.yml`
exclusively for YAML files, standardized "template" workflows which might be applied to projects that have established
the use of the other extension. It will be most flexible if it supports both.
@per1234 per1234 merged commit ecd1837 into arduino:main Aug 6, 2021
@per1234 per1234 deleted the test-updates branch August 6, 2021 09:22
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants